Scroll NumberOfVisibleDays by NumberOfVisibleDays (inspired by #68) #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Glad to see that someone took the time to set up this feature ! (I said I'll do it and I did not do it.) My word is worthless now :'( I hope this will be accepted one day ! I believe it ! |
|
@Quachero How can I clone this pull request? I tried to clone your repository, but it doesn't seem to contain the code presented here , meaning "isScrollNumberVisibleDays" isn't present... |
|
@Quachero Anyway, after manually getting the files, I've found a bug in this code: |
AndroidDeveloperLB
added a commit
to AndroidDeveloperLB/Android-Week-View
that referenced
this pull request
May 7, 2018
…es some delicate work. -fixed some time/date formatting related issues: alamkanak#497 alamkanak#495 (but not fixed RTL alignment issue) -created a new activity to demonstrate the paging of entire view (example: week by week snapping), based on this pull request: Quivr#88
|
I've prepared a pull request that contains those changes, together with some fixes of issues I've found, and conversion to 100% Kotlin code : Sadly, some issues that I've found still exist:
|
hermansje
pushed a commit
to hermansje/Android-Week-View
that referenced
this pull request
May 15, 2018
…es some delicate work. -fixed some time/date formatting related issues: alamkanak#497 alamkanak#495 (but not fixed RTL alignment issue) -created a new activity to demonstrate the paging of entire view (example: week by week snapping), based on this pull request: Quivr#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enable the scroll by the amount of days setted in NumberOfVisibleDays.
It's inspired by the work of SkyleKayma (pullrequest : #68) with some changes like the possibility to enable or not the scroll by the amount of days setted in NumberOfVisibleDays, ... and it's adapted to the last version of Week View library.