Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add issue templates #250

Merged
merged 21 commits into from
Sep 4, 2024
Merged

add issue templates #250

merged 21 commits into from
Sep 4, 2024

Conversation

woodiertexas
Copy link
Contributor

@woodiertexas woodiertexas commented Sep 4, 2024

issue templates are based on the ones found in QuiltMC/quilt-standard-libraries#380


See preview on Cloudflare Pages: https://preview-250.quiltmc-org.pages.dev

Copy link
Contributor

@Southpaw1496 Southpaw1496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these!

In addition to the changes I've requested, could you also add an issue type for submitting content issues? The technical term is "errata" but that might be a little obtuse. The description could be something like "Report an issue with the content on the website"

Can you also make the file extensions .yaml? That will be consistent with the rest of the files in the project.

I don't suppose there's any way to preview how these will look before they're merged into main?

.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
validations:
required: true

- type: textarea
Copy link
Contributor

@Southpaw1496 Southpaw1496 Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the Additional Information field is necessary since the one above it is free text.

.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
@woodiertexas
Copy link
Contributor Author

woodiertexas commented Sep 4, 2024

Can you also make the file extensions .yaml? That will be consistent with the rest of the files in the project.

config.yaml won't work in github but the actual issue template files will work regardless if they're .yml or .yaml

@woodiertexas
Copy link
Contributor Author

I don't suppose there's any way to preview how these will look before they're merged into main?

viewing the file works fine:
image

@Southpaw1496
Copy link
Contributor

I can't review your changes while you're pushing commits, so I'll come back when you've finished :)

@Southpaw1496
Copy link
Contributor

You may want to disable Actions on your fork (Settings -> Actions -> Disable Actions) because they won't work without our Cloudflare and Cozy credentials.

@woodiertexas
Copy link
Contributor Author

I can't review your changes while you're pushing commits, so I'll come back when you've finished :)

i mean, i got everything other than the discord link and the "extra context" field because i'm not sure if those actually need to go lol

@Southpaw1496
Copy link
Contributor

Why do you think they should stay?

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/content_issue_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/content_issue_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/content_issue_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/content_issue_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
@woodiertexas
Copy link
Contributor Author

Why do you think they should stay?

i mean, its possible for the issue creator to miss the first "join the discord for support" button

@Southpaw1496
Copy link
Contributor

There are fewer templates than something like QSL for it to get lost in, and I would argue that needing support doesn't really apply to a website that is largely read-only.

@woodiertexas
Copy link
Contributor Author

There are fewer templates than something like QSL for it to get lost in, and I would argue that needing support doesn't really apply to a website that is largely read-only.

oh ok

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/content_issue_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/enhancement.yml Outdated Show resolved Hide resolved
@Southpaw1496 Southpaw1496 merged commit 15d1936 into QuiltMC:main Sep 4, 2024
2 checks passed
@woodiertexas woodiertexas deleted the add-issue-templates branch September 4, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants