-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API page #232
Fix API page #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question : will this include the swagger JS on every page ? If so, how heavy is it ?
No, it will not. |
Anything blocking this? This has been drafted for a month. |
if you check the preview, you'll see that this PR completely breaks i18n |
I see. How has such an issue not been fixed in a month's time? Surely it should take at most a week. |
quilt is all volunteer work, so we can't expect our contributors to always promptly fix issues. one good thing about open source is that someone else can always pick up the work! |
Surely it should also not be using an ancient version of astro and ancient versions of dependencies that break if you update, but here we are. Feel free to check out the changes of this PR and fix the issues with it. |
Ah, I see you've actually addressed the CSS in your original request Question: The page on https://quiltmc.org/api/ is working fine for me, is there something I'm missing? |
seems like the astro update may have fixed it! |
Well, brilliant! |
This PR fixes the api docs page by replacing the previous hackjob with a dedicated swagger-ui package built for astro.
Note
Custom CSS seems to be broken, but will have to be fixed at a later date.
Right now having a slightly-bad-looking API page is better than none at all.
See preview on Cloudflare Pages: https://preview-232.quiltmc-org.pages.dev