Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downloadMojangMappings task #668

Open
wants to merge 3 commits into
base: 1.21.4
Choose a base branch
from

Conversation

supersaiyansubtlety
Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety commented Nov 27, 2024

Adds a downloadMojangMappings task in preparation for #660.

Downloads client and server mappings.

Mappings aren't available for all versions; if unavailable, warnings are logged.

Behavior for missing mappings may need adjusting depending on what tasks end up depending on downloadMojangMappings.

@supersaiyansubtlety supersaiyansubtlety added enhancement new feature or request t: toolchain changes to the quilt mappings toolchain reviews needed please review this PR s: small PRs with less than 200 lines labels Nov 27, 2024
@supersaiyansubtlety supersaiyansubtlety self-assigned this Nov 27, 2024
@supersaiyansubtlety supersaiyansubtlety added the update-base used to notify github actions that the base branch should be updated label Nov 27, 2024
Copy link
Contributor

🚀 Target branch has been updated to 1.21.4-pre2

@github-actions github-actions bot changed the base branch from 1.21.4-pre1 to 1.21.4-pre2 November 27, 2024 05:55
Copy link
Contributor

🚨 Please fix merge conflicts before this can be merged

@github-actions github-actions bot added v: snapshot targets a snapshot version of minecraft outdated this pull request hasn't been updated to the latest version or has merge conflicts and removed update-base used to notify github actions that the base branch should be updated labels Nov 27, 2024
@supersaiyansubtlety supersaiyansubtlety force-pushed the gradle-cleanup+mojmap-download branch from c38bfc4 to da99c88 Compare November 27, 2024 07:33
@supersaiyansubtlety supersaiyansubtlety removed the outdated this pull request hasn't been updated to the latest version or has merge conflicts label Nov 27, 2024
@ix0rai
Copy link
Member

ix0rai commented Nov 29, 2024

looks good! i won't be merging this until the details of how this will work on the plugin side are figured out

@supersaiyansubtlety supersaiyansubtlety added the update-base used to notify github actions that the base branch should be updated label Dec 2, 2024
@github-actions github-actions bot changed the base branch from 1.21.4-pre2 to 1.21.4-rc3 December 2, 2024 23:42
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🚀 Target branch has been updated to 1.21.4-rc3

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Dec 2, 2024
@supersaiyansubtlety supersaiyansubtlety added the update-base used to notify github actions that the base branch should be updated label Dec 4, 2024
@github-actions github-actions bot changed the base branch from 1.21.4-rc3 to 1.21.4 December 4, 2024 00:35
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🚀 Target branch has been updated to 1.21.4

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature or request reviews needed please review this PR s: small PRs with less than 200 lines t: toolchain changes to the quilt mappings toolchain v: snapshot targets a snapshot version of minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants