Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Customizing your Mappings" article #86

Merged
merged 10 commits into from
Apr 25, 2024

Conversation

IotaBread
Copy link
Member

@IotaBread IotaBread commented Feb 22, 2024

Tried to explain mappings as simple as possible so anyone (with some java knowledge of course) could understand


See preview on Cloudflare Pages: https://preview-86.developer-wiki.pages.dev

Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break up the paragraphs into one line per sentence with breaks between paragraphs, makes it easier to review and a smaller diff.

wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller nitpicks

wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
@ix0rai ix0rai added content Relates to the content of the wiki new page adds a new wiki page labels Feb 23, 2024
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicky changes for an absolutely brilliant article!

wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
wiki/misc/mappings/en.md Outdated Show resolved Hide resolved
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fantastic!

@IotaBread IotaBread requested a review from OroArmor February 26, 2024 01:31
@ix0rai
Copy link
Member

ix0rai commented Mar 25, 2024

@OroArmor it's been exactly a month, please read through this again!

@ix0rai
Copy link
Member

ix0rai commented Apr 20, 2024

FCP for two days!

@ix0rai ix0rai merged commit c467e34 into QuiltMC:main Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Relates to the content of the wiki final comment period new page adds a new wiki page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants