Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientable Blocks wiki page #111

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

woodiertexas
Copy link
Contributor

@woodiertexas woodiertexas commented Jul 22, 2024


See preview on Cloudflare Pages: https://preview-111.developer-wiki.pages.dev

@ix0rai ix0rai added the content Relates to the content of the wiki label Jul 23, 2024
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would stick to the same namespace as other tutorials, and provide more info on what an oriented block is

@woodiertexas woodiertexas requested a review from ix0rai September 3, 2024 03:48
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little bare-bones, needs more information for less experienced modders

wiki/blocks/oriented-block/en.md Outdated Show resolved Hide resolved


First off, you will want to make two block model json like the following:
The X, Y, and Z are your blockstate's axis.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be moved, so that the code is directly after you say 'like the following'

}
```

Then you will need to create a class file for the block you're adding. In this example, the file will be called "GlowingBlackwood.java".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd add an explanation for why we need to create a dedicated class for the block -- explain that it needs custom code in order to work


`src/main/com/example/example_mod/blocks/GlowingBlackwood.java`:
```java
public class BeamBlock extends PillarBlock {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain this code!! why is it called BeamBlock when we're making a log? what do all those methods do? all that will confuse a new modder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(by explain the code, i mean break it into smaller chunks and explain in the article instead of comments. I'd first present the rotate method, explain it, then explain the getPlacementState method)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Relates to the content of the wiki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants