Updated dependencies #14
Conversation
|
|
||
| implementation project(':annotations') | ||
| implementation "io.realm:realm-annotations:$realm_version" | ||
|
|
||
| kapt "com.google.auto.service:auto-service:1.0-rc2" // don't update yet, won't auto generate code | ||
| compileOnly "com.google.auto.service:auto-service:1.0-rc2" // don't update yet, won't auto generate code | ||
|
|
||
| implementation 'com.squareup:javapoet:1.9.0' | ||
| implementation 'com.squareup:kotlinpoet:1.0.0-RC1' |
There was a problem hiding this comment.
This doesn't break anything? Code is still auto generated?
There was a problem hiding this comment.
Sorry, I didn't mean for any one to review this yet. I'm working on another pr that is based off this branch. For now this is just for me to have the Kotlin poet library in the project.
There was a problem hiding this comment.
@Pauldg7 Split the changes of "org.jetbrains.kotlin:kotlin-stdlib-jre8:$kotlin_version" "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
off of the javapoet to kotlinpoet
There was a problem hiding this comment.
make javapoet to kotlinpoet change
a seprate PR
then code gen code will need modifications
| @@ -7,9 +7,6 @@ buildscript { | |||
| repositories{ | |||
| jcenter() | |||
| } | |||
| dependencies { | |||
There was a problem hiding this comment.
This might be needed for the code generation phase. but I have no idea.
Test things out with the example project. Change some variables around and see if the auto generation works.
| @@ -13,7 +13,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:3.1.0' | |||
| classpath 'com.android.tools.build:gradle:3.1.4' | |||
| //noinspection DifferentKotlinGradleVersion | |||
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" | |||
| classpath "io.realm:realm-gradle-plugin:$realm_version" | |||
There was a problem hiding this comment.
@Pauldg7
be carefull about the bumping of android tools at this time.
The cange between android studio 3.1 and 3.2 will be when you want to touch these.
| @@ -36,7 +36,7 @@ android { | |||
|
|
|||
| dependencies { | |||
| implementation fileTree(include: ['*.jar'], dir: 'libs') | |||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jre8:$kotlin_version" | |||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" | |||
There was a problem hiding this comment.
see comments at
annotationprocessor/build.gradle
change
Depends on paul_kotlin_poet or pr #16