Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nonReentrant and delete some require #97

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add nonReentrant and delete some require #97

wants to merge 8 commits into from

Conversation

jishankai
Copy link
Contributor

@jishankai jishankai commented Jul 7, 2020 •
edited
Loading

Resolves #82

@jishankai jishankai requested review from qizhou, qzhodl and ninjaahhh July 7, 2020 09:09
@qizhou
Copy link
Contributor

qizhou commented Jul 8, 2020

I think there is a misunderstanding here: I think we could use ReentrancyGuard here but replacing "public" to "external" is not finalized yet.

@jishankai jishankai changed the title Update public to external and add nonReentrant and delete some require Add nonReentrant and delete some require Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qzhodl qzhodl qzhodl approved these changes

@qizhou qizhou Awaiting requested review from qizhou

@ninjaahhh ninjaahhh Awaiting requested review from ninjaahhh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StakingPool: bette to use nonReentrant modifier for all the three withdraw methods
3 participants
@jishankai @qizhou @qzhodl