-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 432 #435
fix issue 432 #435
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 89.03% 88.31% -0.73%
==========================================
Files 83 76 -7
Lines 4835 4765 -70
==========================================
- Hits 4305 4208 -97
- Misses 530 557 +27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, only minor changes is needed.
Co-authored-by: Rogerluo <[email protected]>
I think this PR should be merged. Automatic differentiating complex numbers does not make sense. |
fix #432
Change List
sandwich
in YaoBlocks for computing<bra| op |ket>
.expect
function now returns real and errors on complex values.<bra| * |ket>
now returns a number, and throws an error if the qubit number does not match.Fixes the type stability issue
Examples
Note
For
expect(O1 + O2, reg)
, the code is still type unstable, this is due to theAdd
block contains a vector of abstract type.