-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IB Tiered Fee Model #8446
Open
LouisSzeto
wants to merge
17
commits into
QuantConnect:master
Choose a base branch
from
LouisSzeto:feature-ib-tier-fee-model
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add IB Tiered Fee Model #8446
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6772fa3
regulatory fee in IB fee model
LouisSzeto 609cedf
IB Tiered Fee Model
LouisSzeto 8b2d720
option regulatory transaction clearing fee
LouisSzeto 92dab00
add crypto fee structure
LouisSzeto dced9e9
bug fix
LouisSzeto d532be2
add crypto fee test in IB original fee model
LouisSzeto 7a14926
add tier model unit test structure
LouisSzeto 03f3b33
add monthly rolling logic and test
LouisSzeto f4f3b5c
add regression algorithm base
LouisSzeto 3e8b3dc
bug fix
LouisSzeto 3837338
update tests
LouisSzeto 87dab18
empty commit
LouisSzeto e66ab8e
shared functions and objects through helper class
LouisSzeto 84e4be8
revert redundnacies, fix bugs
LouisSzeto d26361c
python version
LouisSzeto d6b94be
fix bugs
LouisSzeto fbd8c90
Merge branch 'master' into feature-ib-tier-fee-model
LouisSzeto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
559 changes: 32 additions & 527 deletions
559
Common/Orders/Fees/InteractiveBrokersTieredFeeModel.cs
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
224 changes: 112 additions & 112 deletions
224
Tests/Common/Orders/Fees/InteractiveBrokersFeeModelTests.cs
Large diffs are not rendered by default.
Oops, something went wrong.
600 changes: 300 additions & 300 deletions
600
Tests/Common/Orders/Fees/InteractiveBrokersTieredFeeModelTests.cs
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to run at least a few of these tests for the Python model as well? Just to make sure they are always kept the same when changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: @LouisSzeto 👁️