Simplify merging process #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging the `kwargs` with the `@@default_kwargs` is needed only once before calling the `@block`. The method `sample` calls the method `call`, and the method `call` calls the method `generate`. Therefore, when merge processing is performed only at the `generate`, the merging processing will be executed only once by the `sample` and the `call`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary merges Merging the
kwargswith the@@default_kwargsis needed only once before calling the@block.The method
samplecalls the methodcall, and the methodcallcalls the methodgenerate.Therefore, when merge processing is performed only at the
generate, the merging processing will be executed only once by thesampleand thecall.