Fix for more unit tests fails #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowetic
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Added additional missing featureTriggers to test settings. Thanks @QuickMythril
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer feature triggers are missing from the testchain json files, which causes a very large amount of the unit tests to fail immediately. This pull request adds the missing feature triggers to the remaining testchain json files, continuing from #209 and replacing the closed PR #215 and adds extra logging to some of the unit tests that take a long time with no output. The newest feature triggers from the 4.6.2 release were also causing tests to fail and have been added.