Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pydantic #2675

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Dec 20, 2024

Summary

  • This is a very early poc
  • This has no pretension to get merged
  • This is mostly me trying things out here and there
  • Give feedback if you want

fixes #2642

The goal is to

  • Set up a robust migration system allowing for pydantic and non pydantic types to cohabit.
  • Migrate the main types to pydantic models
  • Add lots of typing

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradual Migration from TypedDict to Pydantic Models
1 participant