-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Filter #342
base: main
Are you sure you want to change the base?
add Filter #342
Conversation
if ( | ||
isinstance(resource.parent, Plate) | ||
and resource.parent.has_lid() | ||
and not isinstance(resource.parent.lid, Filter) | ||
): | ||
raise ValueError("Aspirating from a well with a non-filter lid is not supported.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about making Filter inherit from Resource directly rather than Lid so that this check is not necessary?
from typing import Optional, Union | ||
|
||
from pylabrobot.liquid_handling.liquid_handler import LiquidHandler | ||
from pylabrobot.resources.carrier import ResourceHolder | ||
from pylabrobot.resources.coordinate import Coordinate | ||
from pylabrobot.resources.plate import Lid, Plate | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wanna put this file in pylabrobot/resources/filter.py?
# Retro Filter V4 | ||
|
||
<img src="RetroFilterV4.png" width="800" /> | ||
|
||
Designed for flow cytometry prep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall i move this to the docs so it's on the website? i would add it under liquid handling in the user guide
No description provided.