-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make persistent storage synchronization interval configurable #1285
base: openssl
Are you sure you want to change the base?
Conversation
will be merged after release 2.23 |
{ | ||
SaveUpdated (); | ||
RemoveExpired (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing every minute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the old SaveUpdated
did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must be with interval as specified in this config parameter. Otherwise you might end up with empty netdb quickly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay. As far as I can see, doing it less frequently allows netdb to bloat uncontrollably. One apparent issue that needs to be fixed is that recently updated (IsUpdated() == true
) but now unreachable records are deleted from netdb, which deviates from existing behaviour. Otherwise netdb service does the same thing, except for less frequent disk writes. If there is something else I fail to see, please, tell me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also persisting netDb on exit does not work with the default systemd unit's stop signal - SIGQUIT.
d417a9b
to
38a2d45
Compare
Why this PR not closed yet? As I know, it was merged after 2.23? |
Потому что не фонтан |
The option allows users to make disk io/memory usage tradeoffs themselves. Zero interval means saving only at exit, profiles are stored in memory.