Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian 12 Bookworm #56

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

rgrizzell
Copy link

I wasn't able to test the Vagrant changes due to hardware constraints. It's included for completeness, but I can remove them if its not needed.

@mattock
Copy link
Member

mattock commented Nov 28, 2023

If you're not able to test with Vagrant then I suggest just leaving that part out. I don't have a working Vagrant setup myself, either. Vagrant seems to be slowly dying anyways, which is a shame in this kind use cases.

This PR could just include the trivial part, that is /(trusty|xenial|bionic|buster|focal|bullseye|jammy|bookworm)/ things. Very easy to get merged then.

@rgrizzell
Copy link
Author

@mattock I removed the Vagrant changes. It seems like someone ambitious might be able to convert that to a docker-compose.yml in the future. It would be much less overhead for my machine.

Thanks for taking the time to review this PR.

@mattock mattock merged commit f773b56 into Puppet-Finland:master Nov 29, 2023
3 checks passed
@mattock
Copy link
Member

mattock commented Nov 29, 2023

Thanks for the contribution @rgrizzell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants