Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor upgrade script to accept custom workspace path as an argument, defaulting to "/tmp" #988

Open
wants to merge 1 commit into
base: ci
Choose a base branch
from
Open

Refactor upgrade script to accept custom workspace path as an argument, defaulting to "/tmp" #988

wants to merge 1 commit into from

Conversation

Pubmatic-Dhruv-Sonone
Copy link
Collaborator

@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone commented Dec 30, 2024 •
edited
Loading

Description

Please add change description or link to ticket, docs, etc.

Checklist:

  • PR commit list is unique (rebase/pull with the origin branch to keep master clean).
  • JIRA number is added in the PR title and the commit message.
  • Updated the header-bidding repo with appropiate commit id.
  • Documented the new changes.

For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade

@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone changed the title Refactor script to accept custom workspace path as an argument, defau… Refactor upgrade script to accept custom workspace path as an argument, defau… Dec 30, 2024
@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone changed the title Refactor upgrade script to accept custom workspace path as an argument, defau… Refactor upgrade script to accept custom workspace path as an argument, defaulting to "/tmp" Dec 30, 2024
pm-priyanka-bagade
pm-priyanka-bagade approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@pm-priyanka-bagade pm-priyanka-bagade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm-priyanka-bagade pm-priyanka-bagade pm-priyanka-bagade approved these changes

@pm-saurabh-narkhede pm-saurabh-narkhede Awaiting requested review from pm-saurabh-narkhede

@Pubmatic-Supriya-Patil Pubmatic-Supriya-Patil Awaiting requested review from Pubmatic-Supriya-Patil

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pubmatic-Dhruv-Sonone @pm-priyanka-bagade