Prebid Upgrade v2.32.0 #985

pm-priyanka-bagade · 2024-12-24T06:41:48Z

No description provided.

@lxj15398019970

Co-authored-by: @lxj15398019970

Co-authored-by: Aman Jain <[email protected]> Co-authored-by: rajatgoyal2510 <[email protected]>

@SmartHubSolutions

Co-authored-by: Wls-demo <[email protected]>

* Add MediaGo bidder adapter * update getBidType * MediaGo bidder add test covarage and update some logic * Change the EP's domain macro replacement to let the Publisher modify the config. * change mediago docs * change mediago docs * 1. follow Go's comment convention 2. remove the unsupported formats instead of leaving them as comments

Co-authored-by: Hina Yadav <[email protected]>

@nickjacob

… bid meta (prebid#3733) authored by @nickjacob

Signed-off-by: Dmitry S <[email protected]>

Co-authored-by: Reda Guermas <[email protected]>

Co-authored-by: Aleksandr Štšepelin <[email protected]>

Co-authored-by: Siddhant Kumar Agrawal <[email protected]> Co-authored-by: Siddhant Kumar Agrawal <[email protected]>

Co-authored-by: Zdravko Kosanovic <[email protected]> Co-authored-by: Dedi Sidi <[email protected]>

)

github-actions · 2024-12-24T06:42:12Z

adapters/admatic/admatic.go

+func getMediaTypeForBid(impID string, imps []openrtb2.Imp) (openrtb_ext.BidType, error) {
+	for _, imp := range imps {
+		if imp.ID == impID {
+			if imp.Banner != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-24T06:42:13Z

adapters/admatic/admatic.go

+		if imp.ID == impID {
+			if imp.Banner != nil {
+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-24T06:42:13Z

adapters/admatic/admatic.go

+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {
+				return openrtb_ext.BidTypeVideo, nil
+			} else if imp.Native != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-24T06:42:14Z

adapters/adtonos/adtonos.go

+	// As a fallback, guess markup type based on requested type - AdTonos is an audio company so we prioritize that.
+	for _, requestImp := range requestImps {
+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-24T06:42:15Z

adapters/adtonos/adtonos.go

+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {
+				return openrtb_ext.BidTypeAudio, nil
+			} else if requestImp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:03:12Z

adapters/admatic/admatic.go

+func getMediaTypeForBid(impID string, imps []openrtb2.Imp) (openrtb_ext.BidType, error) {
+	for _, imp := range imps {
+		if imp.ID == impID {
+			if imp.Banner != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:03:13Z

adapters/admatic/admatic.go

+		if imp.ID == impID {
+			if imp.Banner != nil {
+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:03:14Z

adapters/admatic/admatic.go

+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {
+				return openrtb_ext.BidTypeVideo, nil
+			} else if imp.Native != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:03:15Z

adapters/adtonos/adtonos.go

+	// As a fallback, guess markup type based on requested type - AdTonos is an audio company so we prioritize that.
+	for _, requestImp := range requestImps {
+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:03:16Z

adapters/adtonos/adtonos.go

+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {
+				return openrtb_ext.BidTypeAudio, nil
+			} else if requestImp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:16:08Z

adapters/admatic/admatic.go

+func getMediaTypeForBid(impID string, imps []openrtb2.Imp) (openrtb_ext.BidType, error) {
+	for _, imp := range imps {
+		if imp.ID == impID {
+			if imp.Banner != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:16:09Z

adapters/admatic/admatic.go

+		if imp.ID == impID {
+			if imp.Banner != nil {
+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:16:09Z

adapters/admatic/admatic.go

+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {
+				return openrtb_ext.BidTypeVideo, nil
+			} else if imp.Native != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:16:10Z

adapters/adtonos/adtonos.go

+	// As a fallback, guess markup type based on requested type - AdTonos is an audio company so we prioritize that.
+	for _, requestImp := range requestImps {
+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T07:16:11Z

adapters/adtonos/adtonos.go

+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {
+				return openrtb_ext.BidTypeAudio, nil
+			} else if requestImp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T16:57:06Z

adapters/admatic/admatic.go

+func getMediaTypeForBid(impID string, imps []openrtb2.Imp) (openrtb_ext.BidType, error) {
+	for _, imp := range imps {
+		if imp.ID == impID {
+			if imp.Banner != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T16:57:07Z

adapters/admatic/admatic.go

+		if imp.ID == impID {
+			if imp.Banner != nil {
+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T16:57:08Z

adapters/admatic/admatic.go

+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {
+				return openrtb_ext.BidTypeVideo, nil
+			} else if imp.Native != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T16:57:09Z

adapters/adtonos/adtonos.go

+	// As a fallback, guess markup type based on requested type - AdTonos is an audio company so we prioritize that.
+	for _, requestImp := range requestImps {
+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-30T16:57:10Z

adapters/adtonos/adtonos.go

+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {
+				return openrtb_ext.BidTypeAudio, nil
+			} else if requestImp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-31T05:38:17Z

adapters/admatic/admatic.go

+func getMediaTypeForBid(impID string, imps []openrtb2.Imp) (openrtb_ext.BidType, error) {
+	for _, imp := range imps {
+		if imp.ID == impID {
+			if imp.Banner != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-31T05:38:18Z

adapters/admatic/admatic.go

+		if imp.ID == impID {
+			if imp.Banner != nil {
+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-31T05:38:19Z

adapters/admatic/admatic.go

+				return openrtb_ext.BidTypeBanner, nil
+			} else if imp.Video != nil {
+				return openrtb_ext.BidTypeVideo, nil
+			} else if imp.Native != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-31T05:38:19Z

adapters/adtonos/adtonos.go

+	// As a fallback, guess markup type based on requested type - AdTonos is an audio company so we prioritize that.
+	for _, requestImp := range requestImps {
+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-12-31T05:38:20Z

adapters/adtonos/adtonos.go

+		if requestImp.ID == bid.ImpID {
+			if requestImp.Audio != nil {
+				return openrtb_ext.BidTypeAudio, nil
+			} else if requestImp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

lxj15398019970 and others added 30 commits May 23, 2024 16:05

Yeahmobi: Fix video bug (prebid#3680)

72d040b

Co-authored-by: @lxj15398019970

Medianet: Adds mtype support to be used as BidType (prebid#3658)

9133d2c

Co-authored-by: Aman Jain <[email protected]> Co-authored-by: rajatgoyal2510 <[email protected]>

Move imp validation into ortb package (prebid#3685)

ff9aed5

new alias tredio (prebid#3707)

c528d18

co-authored by @SmartHubSolutions

Yieldmo: Add bid floor currency conversion (prebid#3697)

2b8e8cd

Bidder-specific imp FPD (prebid#3704)

37bcf01

FPD: Don't Merge Arrays (prebid#3708)

c4fde39

Fix: Expect Array Overwrites in Imp FPD Tests (prebid#3725)

ecf3171

Imp FPD: Skip bidder params and native validation (prebid#3720)

32fdbc4

Smaato: Add ORTB2.6 tests (prebid#3646)

7702a78

Upgrade To Go 1.22 (prebid#3686)

e13d786

Vungle: Rename from liftoff (prebid#3727)

2d2bf71

Fix golangci-lint issues (prebid#3679)

1979036

Fix semgrep issue with dgryski Go ruleset (prebid#3719)

a812221

Boldwin: update maintainer email (prebid#3701)

2aa6aea

Co-authored-by: Wls-demo <[email protected]>

New Adapter: Concert (prebid#3651)

fb15da3

New Adapter: Driftpixel (prebid#3684)

4dc4005

Gitignore changes (prebid#3752)

817afeb

OwnAdx: Add cookie sync (prebid#3713)

fe55575

Co-authored-by: Hina Yadav <[email protected]>

add support for setting seat (bidderCode) override + demand source in…

9f2caf9

… bid meta (prebid#3733) authored by @nickjacob

AppNexus: Forward GPID (prebid#3767)

3295c41

IX: save/restore global var in test (prebid#3638)

2a8483b

Signed-off-by: Dmitry S <[email protected]>

Nobid: Add iframe sync support (prebid#3732)

07f3ee2

Co-authored-by: Reda Guermas <[email protected]>

New Adapter: Сointraffic (prebid#3647)

057e25d

Co-authored-by: Aleksandr Štšepelin <[email protected]>

New Adapter: Vidazoo (prebid#3698)

09a3dd4

InMobi: include iframe & native for M-Web (prebid#3682)

8784615

Co-authored-by: Siddhant Kumar Agrawal <[email protected]> Co-authored-by: Siddhant Kumar Agrawal <[email protected]>

OpenWeb: Adapter Refactor + New Endpoint (prebid#3670)

80a90dd

Co-authored-by: Zdravko Kosanovic <[email protected]> Co-authored-by: Dedi Sidi <[email protected]>

PulsePoint: Marking cp/ct params to be either String or Int (prebid#3677

a907ecb

)

Bizzclick: rename bizzclick to blasto (prebid#3688)

670e1d4

prebid-upgrade to 2.32

a549d11

github-actions bot reviewed Dec 24, 2024

View reviewed changes

added builder for ow bidders

2a34b4f

github-actions bot reviewed Dec 30, 2024

View reviewed changes

fixed failure

87f3e3b

github-actions bot reviewed Dec 30, 2024

View reviewed changes

fixed UTs

d508c58

github-actions bot reviewed Dec 30, 2024

View reviewed changes

Merge branch 'ci' into prebid_v2.32.0-1

7f6147c

github-actions bot reviewed Dec 31, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prebid Upgrade v2.32.0 #985

Prebid Upgrade v2.32.0 #985

pm-priyanka-bagade commented Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 30, 2024

github-actions bot Dec 31, 2024

github-actions bot Dec 31, 2024

github-actions bot Dec 31, 2024

github-actions bot Dec 31, 2024

github-actions bot Dec 31, 2024

Prebid Upgrade v2.32.0 #985

Are you sure you want to change the base?

Prebid Upgrade v2.32.0 #985

Conversation

pm-priyanka-bagade commented Dec 24, 2024

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot Dec 31, 2024

Choose a reason for hiding this comment

github-actions bot Dec 31, 2024

Choose a reason for hiding this comment

github-actions bot Dec 31, 2024

Choose a reason for hiding this comment

github-actions bot Dec 31, 2024

Choose a reason for hiding this comment

github-actions bot Dec 31, 2024

Choose a reason for hiding this comment