OTT-1990: select Valid Inline and banner creatives in case of VAST unwrap is enabled for given profile #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e not consuming PublisherID Configured at Partner Account Level (#885)
…rap module (#874) * OTT-1807: discard emptyVAST and invalidVAST bids
OTT-1824: using fastxml for video event injection
…jetc from the signal regs.ext (#893)
Downmerge Master to Ci
RE-3733: Release 12th_Sept_2024
Downmerge 12th September release
* stat for bid recovery * change buckets * introduce new stat
…wrap is enabled for given profile
| args: args{ | ||
| module: OpenWrap{}, | ||
| }, | ||
| wantResult: hookstage.HookResult[hookstage.RawBidderResponsePayload]{DebugMessages: []string{"error: request-ctx not found in handleRawBidderResponseHook()"}}, | ||
| }, | ||
| { | ||
| name: "Set Vast Unwrapper to false in request context with type video", | ||
| name: "Set_Vast_Unwrapper_to_false_in_request_context_with_type_video", |
There was a problem hiding this comment.
Can we make sure below scenarios are covered
- VAST Unwrap disabled with Video Creative only
- VAST Unwrap disabled with Video, Banner Creative
- VAST Unwrap disabled with Banner Creative only
- VAST Unwrap enabled with Video Creative only
- VAST Unwrap enabled with Video, Banner Creative
- VAST Unwrap enabled with Banner Creative only
- VAST Unwrap enabled with Invalid Video Creative only
- VAST Unwrap enabled with Invalid Video, Banner Creative
- VAST Unwrap enabled with Banner Creative only
There was a problem hiding this comment.
Added unit test cases to cover all scenarios
Pubmatic-Supriya-Patil
requested review from
pm-viral-vala and
pm-jaydeep-mohite
| @@ -80,7 +81,7 @@ func TestHandleRawBidderResponseHook(t *testing.T) { | |||
| wantResult: hookstage.HookResult[hookstage.RawBidderResponsePayload]{Reject: false}, | |||
| }, | |||
| { | |||
| name: "Set Vast Unwrapper to false in request context with type video, stats enabled true", | |||
| name: "Set_Vast_Unwrapper_to_false_in_request_context_with_type_video,_stats_enabled_true", | |||
There was a problem hiding this comment.
This can may not be required as we are not capturing only stats.
There was a problem hiding this comment.
Removed test case
| }, | ||
| { | ||
| name: "Set Vast Unwrapper to true in request context with type video", | ||
| name: "Set_Vast_Unwrapper_to_true_in_request_context_with_type_video", |
There was a problem hiding this comment.
Can we update test case names like
VASTUnwrap_Enabled_Single_Video_bid
VASTUnwrap_Enabled_Multiple_Video_bids
VASTUnwrap_Enabled_Baner_Video_bids
VASTUnwrap_Disabled_Single_Video_bid
There was a problem hiding this comment.
Updated
| @@ -39,6 +39,9 @@ func (m OpenWrap) handleRawBidderResponseHook( | |||
| // send bids for unwrap | |||
| for _, bid := range payload.BidderResponse.Bids { | |||
| if !isEligibleForUnwrap(bid) { | |||
| unwrappedBids = append(unwrappedBids, bid) | |||
| result.DebugMessages = append(result.DebugMessages, | |||
There was a problem hiding this comment.
We can remove this printing and add details like total bids, total unwrapping, total success unwrapping counts in debugLog at
There was a problem hiding this comment.
Done
Pubmatic-Dhruv-Sonone
previously approved these changes
Sep 25, 2024
Pubmatic-Supriya-Patil
dismissed stale reviews from Pubmatic-Dhruv-Sonone and pm-jaydeep-mohite
The merge-base changed after approval.
pm-viral-vala
force-pushed
the
ci
branch
2 times, most recently
from
1eadcd8 to
bcc32d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add change description or link to ticket, docs, etc.
Checklist:
header-biddingrepo with appropiate commit id.For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade