Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a minor bug in a test #8223

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

ericspod
Copy link
Member

Description

There is a minor bug in a test which causes a second fail to occur when one does. In test_module_list.py, there is a list of classes to check which must have aliases removed from it. This must be done before the test assert so that in the event the assert fails this removal isn't skipped.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
Copy link
Contributor

KumoLiu commented Nov 21, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) November 21, 2024 08:14
@KumoLiu KumoLiu merged commit b1e915c into Project-MONAI:dev Nov 21, 2024
28 checks passed
@ericspod ericspod deleted the fix_module_test branch November 21, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants