-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable gpu load nifti #8188
enable gpu load nifti #8188
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
ed1de7e
to
ca1cfb8
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
related topic in: nipy/nibabel#1385 Will modify my draft PR accordingly. |
Signed-off-by: Yiheng Wang <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <[email protected]>
Thank you for your contribution! I have a question about this enhancement: Will it load NIfTI/DICOM files to the GPU faster compared to caching all the data on the GPU? If not, does this option use less GPU memory since the metadata is stored on the CPU? Thanks. |
Hi @KumoLiu , these are two different things. The enhanced reader can load nii images from disk to GPU directly (the old way is to load from disk to cpu, and then convert from cpu to gpu), and the loaded data can do other things, like cache as you mentioned. |
Hi @KumoLiu , do you know what is the root cause of the doc error: https://github.com/Project-MONAI/MONAI/actions/runs/12311294929/job/34361260922?pr=8188#step:7:247 |
Yes, you may need include |
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Yiheng Wang <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Yiheng Wang <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Yiheng Wang <[email protected]>
/build |
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
/build |
Related to #8241 .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.