-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8134 Add unit test for responsive inference #8146
Conversation
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Hi @Nic-Ma, we haven't had time to discuss the ideas around realtime/streaming inference yet due to MICCAI, but I feel we should look into doing this with specialised versions of datasets and transforms to represent streams of incoming and outgoing items. This would implement streaming without modifying existing workflows if we can get it performant. |
Hi @ericspod , Yes, I totally agree with you, I was thinking both the streaming way and repeatedly calling way. This PR is just a draft implementation for discussion, could you please help also write draft code for your idea and let's discuss later? Thanks in advance. |
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
for more information, see https://pre-commit.ci
/build |
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
/build |
…add-realtime-infer
Signed-off-by: YunLiu <[email protected]>
/build |
Hi @ericspod, if you don't have any further comments, I will try to merge this one. |
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: YunLiu <[email protected]>
/build |
…add-realtime-infer
Signed-off-by: YunLiu <[email protected]>
/build |
1 similar comment
/build |
Fixes #8134 .
Description
This PR added unit test to cover the realtime inference with bundles.
And updated
BundleWorkflow
to support cyclically calling therun
function with all components instantiated.Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.