Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PyType test to weekly test #8025

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Move PyType test to weekly test #8025

merged 3 commits into from
Aug 19, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Aug 19, 2024

Fixes #8022

Description

  • Add format test to weekly test
  • Set pytype test as not required in each PR
  • Add packaging in weekly-preview pipeline

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Aug 19, 2024

/build

@KumoLiu KumoLiu requested review from ericspod and Nic-Ma August 19, 2024 04:06
@ericspod
Copy link
Member

Hi @Nic-Ma If you're OK with this change so am I. This will speed up doing PRs since we don't have to wait for Pytype to finish but doesn't remove it from our CICD system. Thanks both!

@KumoLiu KumoLiu merged commit 9f56a3a into Project-MONAI:dev Aug 19, 2024
28 checks passed
@KumoLiu KumoLiu deleted the pytype branch August 19, 2024 15:09
rcremese pushed a commit to rcremese/MONAI that referenced this pull request Sep 2, 2024
Fixes Project-MONAI#8022

### Description

- Add format test to weekly test
- Set pytype test as not required in each PR
- Add packaging in weekly-preview pipeline

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider Not Using Pytype in PR tests
2 participants