Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

複数ファイルをaddする機能の追加 #8

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

複数ファイルをaddする機能の追加 #8

wants to merge 7 commits into from
+409 −56

Conversation

hyphen-o
Copy link
Contributor

@hyphen-o hyphen-o commented Oct 4, 2024

やったこと

複数ファイルをaddできる機能とそれに伴うオプションの追加を行いました

詳細

  • add ディレクトリやadd .で複数ファイルをステージングできるように対応
  • commitに -amオプションを追加し，add .とcommitをどちらもできるように変更

確認項目

  • git add .で全ファイルがステージングされている
  • git add ディレクトリ名でそのディレクトリの中身のファイルが全てステージングされている
  • git commit -am message & mygit logで全てのファイルがaddされた上でcommitされている

@hyphen-o hyphen-o marked this pull request as ready for review October 4, 2024 05:19
S-Nakamur-a
S-Nakamur-a approved these changes Oct 4, 2024
View reviewed changes
Copy link

@S-Nakamur-a S-Nakamur-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/commands/add.ts
Comment on lines +18 to +20
if (filePath === ".git") {
return;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good-badge
ナイスハンドリングです

Base automatically changed from keigo-okamoto/feature-add-commit-dump to main October 4, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Nakamur-a S-Nakamur-a S-Nakamur-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyphen-o @S-Nakamur-a