Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treeモデルの作成 #6

Merged
merged 3 commits into from
Oct 4, 2024
Merged

treeモデルの作成 #6

merged 3 commits into from
Oct 4, 2024
+224 −2

Conversation

hyphen-o
Copy link
Contributor

@hyphen-o hyphen-o commented Oct 3, 2024

やったこと

treeモデルの作成

詳細

  • treeクラスの作成
  • treeオブジェクトの生成・dumpする機能の実装
  • commitコマンドの追加

確認項目

  • mygit add XXをしてファイルをステージング
  • mygit commit -m XX でrootTreeHashが出力される
  • git cat-file -p rootTreeHashで中身が参照できる

@hyphen-o hyphen-o marked this pull request as ready for review October 4, 2024 01:24
@hyphen-o hyphen-o requested a review from S-Nakamur-a October 4, 2024 01:24
S-Nakamur-a
S-Nakamur-a approved these changes Oct 4, 2024
View reviewed changes
Copy link

@S-Nakamur-a S-Nakamur-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コード綺麗ですね

src/models/tree-object.ts
}

//ファイルパスとハッシュからファイル構造を構築
private buildFileSystem(fileData: Array<FileData>): void {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits-badge
dataが単複同形なので難しいですが、fileDataArray とかで逃げちゃうのもアリかと！

@hyphen-o hyphen-o merged commit fc4d0ea into main Oct 4, 2024
1 check passed
@hyphen-o hyphen-o deleted the keigo-okamoto/feature-add-tree-model branch October 4, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Nakamur-a S-Nakamur-a S-Nakamur-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyphen-o @S-Nakamur-a