This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Enhacement: Go Version segment uses Go colours and only the version number is shown. #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisse-dev
force-pushed
the
feature/enhace-go-segment
branch
2 times, most recently
from
ba5dece to
8c2d08a
Compare
…umber is shown. 1. Why is this change neccesary? Because the go_version segment had a green background when other segments (like rbenv) have a colour that matches the language. The Go version had the string "go" before the semantic versioning being redundant to have the Gopher icon and the String. The segment was only visible when inside the GOPATH, and some users (like me) may be interested in the segment being shown persistently. 2. How does it address the issue? The background colour was changed from green to cyan and the foreground colour from white to black in order to match Go colours. Only the version of Go is shown in the segment. A variable was added to see the segment persistently if the user wishes to. 3. What side effects does this change have? None!
denisse-dev
force-pushed
the
feature/enhace-go-segment
branch
from
8c2d08a to
27b38c5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change neccesary?
Because the go_version segment had a green background when other segments (like
rbenv) have a colour that matches the language.
The Go version had the string "go" before the semantic versioning being
redundant to have the Gopher icon and the String.
The segment was only visible when inside the GOPATH, and some users (like me)
may be interested in the segment being shown persistently.
How does it address the issue?
The background colour was changed from green to cyan and the foreground colour
from white to black in order to match Go colours.
Only the version of Go is shown in the segment.
A variable was added to see the segment persistently if the user wishes to.
What side effects does this change have?
None however, I need help with the SVG as I have no clue on how to do it.
Before:
After:
Update: I've added the SVG.