Switch to Stack on CircleCI #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| override: | ||
| - stack test | ||
| - git ls-files | grep '\.l\?hs$' | xargs stack exec -- hlint -X QuasiQuotes "$@" | ||
| - stack exec -- packdeps *.cabal || true |
There was a problem hiding this comment.
Doesn't packdeps lose a bit of it's purpose when we build with stack?
There was a problem hiding this comment.
I was thinking if someone wanted to use the modules in postgrest from their own haskell project that I want to make sure they wouldn't have to hold common dependencies back at old versions. Many of our deps have constraints on their major version.
Packdeps is treated as a warning here (for instance I don't want to upgrade to aeson 10 because it has a bug).
There was a problem hiding this comment.
What would also be good is adding packunused to help us prune packages we no longer need. At the moment is has stack problems though.
|
Rock n'Roll 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new config has a few benefits