Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): hide unallowed categories #3264

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bouttier
Copy link
Contributor

@bouttier bouttier commented Nov 20, 2024

Fixes #3262

  • Pour import, il faut une permission sur le module import objet import, n’importe quelle action.
  • La prochaine version du module d’export pourra rajouter une contraintes identiques.
  • Pour la modification du statut de validation ou le commentaire sur une observation, les notifications sont envoyées aux observateurs et au digitaliser. En conséquence, pas de contrainte.
  • Pour les demandes de permissions, il y aura une contraintes action C pour les notifs au demandeur, et une contrainte action V pour les notifs aux admins.

@bouttier bouttier force-pushed the feat/hide-notifs branch 2 times, most recently from e672283 to da9a519 Compare November 20, 2024 20:06
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.89%. Comparing base (b91808b) to head (42070a8).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
backend/geonature/core/notifications/models.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3264      +/-   ##
===========================================
+ Coverage    83.84%   83.89%   +0.04%     
===========================================
  Files          122      122              
  Lines         9647     9667      +20     
===========================================
+ Hits          8089     8110      +21     
+ Misses        1558     1557       -1     
Flag Coverage Δ
pytest 83.89% <96.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@camillemonchicourt
Copy link
Member

Je pense pas qu'il faille utiliser l'action V.
C'est un action qu'on avait imaginé au départ dans les différents modules mais au final on a retenu de faire un module global et dédié aux validations.

On a donc plusieurs fois évoqué la volonté de supprimer cette action V.

@jacquesfize jacquesfize added this to the 2.16 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants