-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add detached CLI option #87
Conversation
23d8478
to
d4d3e3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you fix the build?
d4d3e3b
to
e0a6ffb
Compare
oops, I moved the option after testing because I realized it wasn't in order and messed up the function calls. Ran the CI tests locally, so hopefully will pass in GHA now. |
Doesn't adding this flag break the "down" subcommand again? That's the whole reason why we've removed it and all other "up" arguments. Discussion is here: #82 I mean, I'm happy the "detached" option is back, but if "down" doesn't work, how can we stop the processes? |
Huh, good catch. #83 would have caught this. |
I guess I just won't use the wrapper then, and will use process-compose directly with the generated config. Though the wrapper could maybe conditionally expose the CLI args depending on if it's an up event or not. |
@adamcstephens You can still use wrapper, like this:
i.e., you need to pass the subcommand ( |
Cool, thanks. |
No description provided.