Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add detached CLI option #87

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

adamcstephens
Copy link
Contributor

No description provided.

Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you fix the build?

@adamcstephens
Copy link
Contributor Author

adamcstephens commented Nov 8, 2024

oops, I moved the option after testing because I realized it wasn't in order and messed up the function calls. Ran the CI tests locally, so hopefully will pass in GHA now.

@srid srid merged commit b590e39 into Platonic-Systems:main Nov 8, 2024
3 checks passed
@adamcstephens adamcstephens deleted the add-detached branch November 8, 2024 02:09
@VanCoding
Copy link
Contributor

Doesn't adding this flag break the "down" subcommand again? That's the whole reason why we've removed it and all other "up" arguments. Discussion is here: #82

I mean, I'm happy the "detached" option is back, but if "down" doesn't work, how can we stop the processes?

@srid
Copy link
Member

srid commented Nov 8, 2024

Huh, good catch. #83 would have caught this.

srid added a commit that referenced this pull request Nov 8, 2024
srid added a commit that referenced this pull request Nov 8, 2024
@adamcstephens
Copy link
Contributor Author

I guess I just won't use the wrapper then, and will use process-compose directly with the generated config. Though the wrapper could maybe conditionally expose the CLI args depending on if it's an up event or not.

@srid
Copy link
Member

srid commented Nov 8, 2024

@adamcstephens You can still use wrapper, like this:

nix run . up --detached

i.e., you need to pass the subcommand (up) explicitly.

@adamcstephens
Copy link
Contributor Author

Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants