Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add writeBatch #81

Merged
merged 4 commits into from
Oct 29, 2024
Merged

add writeBatch #81

merged 4 commits into from
Oct 29, 2024

Conversation

tinect
Copy link
Collaborator

@tinect tinect commented Oct 21, 2024

While such feature will come (thephpleague/flysystem#1778), I like to add a possibility by now.

To transfer many files will result in long-running tasks, e.g.:
Shopware assets:install: 2 hours and 37 minutes
With this change: 33 seconds

Shopware theme:compile: 30 secs
With this change: 5 secs

What do you think about it? Should I try adding tests?

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 39 lines in your changes missing coverage. Please review.

Project coverage is 73.43%. Comparing base (afb885b) to head (cd1a5a2).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/BunnyCDNClient.php 4.00% 24 Missing ⚠️
src/BunnyCDNAdapter.php 12.50% 14 Missing ⚠️
src/WriteBatchFile.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #81      +/-   ##
============================================
- Coverage     75.29%   73.43%   -1.86%     
- Complexity      122      129       +7     
============================================
  Files             3        4       +1     
  Lines           255      256       +1     
============================================
- Hits            192      188       -4     
- Misses           63       68       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tinect
Copy link
Collaborator Author

tinect commented Oct 28, 2024

Hey @sifex
I hope you're doing well. I was wondering if you might have some time to have a look at the PR I've been working on? Your feedback would be greatly appreciated!

@sifex sifex merged commit ca6504e into PlatformCommunity:master Oct 29, 2024
3 checks passed
@sifex
Copy link
Collaborator

sifex commented Oct 29, 2024

Thanks @tinect, Merged ☺️

@tinect tinect deleted the feat/writeBatch branch October 29, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants