-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure FindEigen3.cmake is not used #126
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 11 11
Lines 223 223
=======================================
Hits 220 220
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@christophfroehlich Would you please try this out for me? If you check out |
I have RSL, generate_parameter_library, and cpp_polyfills in my workspace. With the main branch:
With this fix, it builds and colcon test succeeds also. Same with downstream control_toolbox package, so I guess this fixes my workflow mentioned in #114. Thanks again for fixing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Oversight from #125 since we don't test the install interface on RHEL.