Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets to env when building storybook #506

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

meisekimiu
Copy link
Member

I forgor to actually supply required secrets. Thankfully, these tokens aren't actually used, they just need to be defined at all so we don't even need to supply an actual token for these.

PER-9954: Generate secrets as part of Storybook build

I forgor to actually supply required secrets. Thankfully, these tokens
aren't actually used, they just need to be defined at all so we don't
even need to supply an actual token for these.

PER-9954: Generate secrets as part of Storybook build
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.20%. Comparing base (64d5c02) to head (768bfb1).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   43.10%   43.20%   +0.09%     
==========================================
  Files         363      363              
  Lines       11102    11102              
  Branches     1809     1809              
==========================================
+ Hits         4786     4797      +11     
+ Misses       6154     6141      -13     
- Partials      162      164       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meisekimiu meisekimiu marked this pull request as ready for review December 12, 2024 19:20
@meisekimiu
Copy link
Member Author

Since I messed with dev's apache config and the dev load balancer, you can actually test that works by verifying no stories have weird errors (especially the onboarding demo or directive stories) on the instance of Storybook deployed to dev under this branch. (At /storybook on dev)

@meisekimiu meisekimiu merged commit b19e989 into main Dec 12, 2024
14 checks passed
@meisekimiu meisekimiu deleted the storybook-supply-secrets branch December 12, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants