Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate secrets when building for Storybook #505

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

meisekimiu
Copy link
Member

While no API keys are needed in Storybook, the components in the web-app still expect all of our secret constants to be defined and some components are broken in static Storybook builds. Generate secrets before doing any static Storybook builds to address this.

PER-9954: Generate secrets as part of Storybook build

While no API keys are needed in Storybook, the components in the web-app
still expect all of our secret constants to be defined and some
components are broken in static Storybook builds. Generate secrets
before doing any static Storybook builds to address this.

PER-9954: Generate secrets as part of Storybook build
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.23%. Comparing base (806f579) to head (0966600).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   43.20%   43.23%   +0.02%     
==========================================
  Files         363      363              
  Lines       11102    11102              
  Branches     1809     1809              
==========================================
+ Hits         4797     4800       +3     
+ Misses       6144     6140       -4     
- Partials      161      162       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meisekimiu meisekimiu merged commit 64d5c02 into main Dec 12, 2024
4 checks passed
@meisekimiu meisekimiu deleted the storybook-run-secrets branch December 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants