PER-9943-cant-delete-sms-mfa #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle 11 character phone numbers(with country code) in SMS MFA setup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 43.10% 43.15% +0.04%
==========================================
Files 362 362
Lines 11042 11056 +14
Branches 1799 1805 +6
==========================================
+ Hits 4760 4771 +11
- Misses 6121 6122 +1
- Partials 161 163 +2 ☔ View full report in Codecov by Sentry. |
meisekimiu
reviewed
Dec 11, 2024
Comment on lines
+70
to
+74
| const match = numbers.match(/^(\d{1,3})/); | ||
| if (match) { | ||
| countryCode = `+${match[1]}`; | ||
| numbers = numbers.substring(match[1].length); | ||
| } |
There was a problem hiding this comment.
Can you add coverage for these paths of code? The other ones have examples provided in the tests and it would be nice to see that spelled out for this branch as well.
|
@meisekimiu you are right, test added :) |
meisekimiu
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle 11 character phone numbers(with country code) in SMS MFA setup
Steps to test: