Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PER-9916-exiting-onboarding-on-refresh #501

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

crisnicandrei
Copy link
Contributor

Because of a user having no archive during onboarding, the onboarding process would throw an error each time the page would refresh, loggging the user out.

I have fixed that problem and added the current steps of onboarding to the session storage so that the user can continue where they left off after refreshing, but if the tab is closed all the progress is being erased

Steps to test:

  1. Create a new archive
  2. Go to the onboarding page
  3. Refresh and the user should still be logged in
  4. Go through each process, refreshing each itme, and the data should persist

@crisnicandrei crisnicandrei force-pushed the PER-9916-exiting-onboarding branch from e7acf3f to c4a8fb6 Compare December 9, 2024 17:22
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 43.09%. Comparing base (eb1bab3) to head (1f86c99).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...create-new-archive/create-new-archive.component.ts 29.03% 22 Missing ⚠️
src/app/core/guards/auth.guard.ts 23.07% 10 Missing ⚠️
...ype-screen/select-archive-type-screen.component.ts 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   43.10%   43.09%   -0.02%     
==========================================
  Files         362      362              
  Lines       11042    11094      +52     
  Branches     1799     1809      +10     
==========================================
+ Hits         4760     4781      +21     
- Misses       6121     6150      +29     
- Partials      161      163       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8lyn6 k8lyn6 self-requested a review December 11, 2024 16:49
Copy link

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! It works perfectly. Thanks Andrei!

Because of a user having no archive during onboarding, the onboarding process would throw an error each time the page would refresh, loggging the user out.

I have fixed that problem and added the current steps of onboarding to the session storage so that the user can continue where they left off after refreshing, but if the tab is closed all the progress is being erased
@crisnicandrei crisnicandrei force-pushed the PER-9916-exiting-onboarding branch from 45d641d to 1f86c99 Compare December 12, 2024 08:42
@crisnicandrei crisnicandrei merged commit 0cc75ce into main Dec 12, 2024
4 checks passed
@crisnicandrei crisnicandrei deleted the PER-9916-exiting-onboarding branch December 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants