Use FontAwesome Pro Icons #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisekimiu
force-pushed
the
fontawesome-pro
branch
from
9458600 to
84a2ef2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 43.20% 43.19% -0.01%
==========================================
Files 363 363
Lines 11102 11102
Branches 1809 1809
==========================================
- Hits 4797 4796 -1
- Misses 6143 6144 +1
Partials 162 162 ☔ View full report in Codecov by Sentry. |
meisekimiu
force-pushed
the
fontawesome-pro
branch
from
84a2ef2 to
fe795e9
Compare
|
@k8lyn6 Do you know which icons we want to use for the "other" and "unsure" archive types in onboarding? I can't find them in the design. |
|
@meisekimiu I do not know. I'll ask Tibi! |
liam-lloyd
approved these changes
Dec 11, 2024
meisekimiu
force-pushed
the
fontawesome-pro
branch
from
8cf54a2 to
80aa417
Compare
yeslikesolo
approved these changes
Dec 12, 2024
To actually install the packages you'll need a FontAwesome Package Token. Then you can run: ``` FONTAWESOME_PACKAGE_TOKEN="(token)" npm install ``` PER-9893: Use FontAwesome Pro Icons
PER-9893: Use FontAwesome Pro in Glam Onboarding
Finally fill out the descriptions for "Other" and "Unsure" archive types in Glam onboarding. PER-9893: Use FontAwesome Pro icons
PER-9893: Use FontAwesome Pro Icons
PER-9893: Use FontAwesome Pro in Glam Onboarding
meisekimiu
force-pushed
the
fontawesome-pro
branch
from
ebf7e21 to
cfa1223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FontAwesome Pro icons in the Glam onboarding and fill in the descriptions for the "other" and "unsure" archive types. Note that you will now need a FontAwesome token to install dependencies on this project:
FONTAWESOME_PACKAGE_TOKEN="insert_token_here" npm installSteps to test: