Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PER-9762-update-glam-onboarding #485

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

crisnicandrei
Copy link
Contributor

Design changes to the mobile onboarding flw

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.64%. Comparing base (d2743d1) to head (ca0cd95).
Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   42.68%   42.64%   -0.04%     
==========================================
  Files         357      357              
  Lines       10981    10981              
  Branches     1795     1795              
==========================================
- Hits         4687     4683       -4     
- Misses       6138     6139       +1     
- Partials      156      159       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crisnicandrei crisnicandrei requested a review from k8lyn6 October 31, 2024 14:23
Copy link

@k8lyn6 k8lyn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! I also tested non-glam onboarding to make sure that nothing changed there.

Design changes to the mobile onboarding flw
@crisnicandrei crisnicandrei force-pushed the PER-9762-update-glam-onboarding-mobile branch from 24124e3 to ca0cd95 Compare November 1, 2024 13:58
@crisnicandrei crisnicandrei merged commit 5ae4183 into main Nov 1, 2024
4 checks passed
@crisnicandrei crisnicandrei deleted the PER-9762-update-glam-onboarding-mobile branch November 1, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants