PER-9881: The location picker never closes #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 42.10% 42.47% +0.37%
==========================================
Files 354 354
Lines 10952 10954 +2
Branches 1788 1789 +1
==========================================
+ Hits 4611 4653 +42
+ Misses 6190 6141 -49
- Partials 151 160 +9 ☔ View full report in Codecov by Sentry. |
meisekimiu
reviewed
Oct 21, 2024
Comment on lines
+171
to
+176
| onLocationEnterPress(e: KeyboardEvent): void { | ||
| if (this.canEdit && e.key === 'Enter') { | ||
| this.editService.openLocationDialog(this.selectedItem); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you cover this function with some basic tests? You do not need to cover the rest of the component for now.
meisekimiu
approved these changes
Oct 22, 2024
|
@meisekimiu it seems codecov still isn't happy, but i will add the other tests myself. Thank you for your help on that one!😄 |
Change the focus event to keydown event so the location picker closes when the user presses done.
A Pipe was being mocked by shallow-render when we didn't want it to be. Add a `dontMock` section with the `asRecord` pipe provided. Also add a null check to `selectedItem.FileVOs`, which seemed to be triggering issues in tests. Clean up some of the code formatting and unnecessary lines in the SidebarComponent tests while we're there.
crisnicandrei
force-pushed
the
PER-9881-the-location-picker-never-closes
branch
from
afbbc8a to
d074975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the focus event to keydown event so the location picker closes when the user presses done.
Steps to test:
Open the location picker and select a location, then click done.
The location picker should close