Remove unused LoadingArchiveComponent #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-lloyd
approved these changes
Apr 1, 2024
|
Requesting QA on this one just to be safe. In theory there are no user-facing changes but perhaps this breaks something I didn't see? For QA one should mainly check that you can still switch archives. |
k8lyn6
approved these changes
Apr 2, 2024
The LoadingArchiveComponent was created to be an interstitial component displayed when switching archives in commit 76883bd. However, as time has gone on, the `/app/switching` path became unused. Since this specific LoadingArchiveComponent was only used in this one route, the component itself became unused. This component has problematic tests. They are (relatively) slow since they wait 2.5 seconds just for one test, and also sometimes fail due to random asyncronous errors. While we could optimize the component to fix these errors, since the component is unused we should just delete it and the problematic tests. Resolves PER-9520
meisekimiu
force-pushed
the
remove-loading-archive-component
branch
from
06a4a7a to
5292b8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
=======================================
Coverage 36.74% 36.75%
=======================================
Files 308 307 -1
Lines 10615 10611 -4
Branches 1763 1763
=======================================
- Hits 3901 3900 -1
+ Misses 6572 6569 -3
Partials 142 142 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LoadingArchiveComponent was created to be an interstitial component displayed when switching archives in commit 76883bd. However, as time has gone on, the
/app/switchingpath became unused. Since this specific LoadingArchiveComponent was only used in this one route, the component itself became unused. Presumably it stayed around because it sounds important!This component has problematic tests. They are (relatively) slow since they wait 2.5 seconds just for one test, and also sometimes fail due to random asynchronous errors. While we could optimize the component to fix these errors, since the component is unused we should just delete it and the problematic tests.
Steps to test:
Resolves PER-9520.