PER-9446-form input #358
Merged
PER-9446-form input #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisnicandrei
force-pushed
the
PER-9446-form-input
branch
from
383faa2 to
b2e940e
Compare
|
Looks like the linting is failing, probably because of the conflicts @crisnicandrei -- can you rebase and fix any lint errors? Thanks! |
crisnicandrei
force-pushed
the
PER-9446-form-input
branch
from
07b0b27 to
6f3e551
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 35.59% 35.97% +0.38%
==========================================
Files 299 303 +4
Lines 10379 10480 +101
Branches 1719 1742 +23
==========================================
+ Hits 3694 3770 +76
- Misses 6540 6561 +21
- Partials 145 149 +4 ☔ View full report in Codecov by Sentry. |
meisekimiu
approved these changes
Feb 22, 2024
Implementation of the form input component from the new component library. I have kept the old implementation and added a way to also use it without a form control, also using a debounce + style changes
crisnicandrei
force-pushed
the
PER-9446-form-input
branch
from
07bde88 to
635cba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the form input component from the new component library.
I have kept the old implementation and added a way to also use it without a form control, also using a debounce + style changes.
This pr also includes the new fonts for the new design system.