Per 9185 update public archive design #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 33.67% 33.61% -0.06%
==========================================
Files 268 268
Lines 9720 9722 +2
Branches 1613 1613
==========================================
- Hits 3273 3268 -5
- Misses 6320 6326 +6
- Partials 127 128 +1 ☔ View full report in Codecov by Sentry. |
crisnicandrei
force-pushed
the
PER-9185-update-public-archive-design
branch
from
09aa24b to
27a7dbe
Compare
k8lyn6
requested changes
Nov 15, 2023
There was a problem hiding this comment.
It's a little hard to tell what was changed, but here are a few things I found (they could've been existing, I'm not sure):
- Did the banner get larger? I think it's taking up too much room. I think we should go back to what it was if it was changed.
- The search bar is getting cut off a little when the browser is a certain size. See photo below:
- When you search for something and get a result that has a very long title, the image thumbnail is getting cut off. See photo below:
crisnicandrei
force-pushed
the
PER-9185-update-public-archive-design
branch
from
eea76ce to
66bfd6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the design of the public archive.
@k8lyn6 if you see something that is off please let me know and i will take care of it.