Enable @angular-eslint/template/eqeqeq linting rule #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisekimiu
force-pushed
the
lint/@angular-eslint/template/eqeqeq
branch
from
e20a8fd to
1132bea
Compare
Add tests to the file-browser component before adding a new linting rule that will cause us to modify some of the component template. Lint rule: @angular-eslint/template/eqeqeq
The file for the file-viewer tests was named `file-view.component.spec.ts`. Rename it to `file-viewer.component.spec.ts` to match the rest of the component filenames. Lint rule: @angular-eslint/template/eqeqeq
The `@angular-eslint/template/eqeqeq` linting rule forbids usage of the == operator in Angular component templates, preferring the more type safe === operator instead. Lint rule: @angular-eslint/template/eqeqeq
meisekimiu
force-pushed
the
lint/@angular-eslint/template/eqeqeq
branch
from
1132bea to
532a81e
Compare
meisekimiu
commented
Oct 27, 2023
| @@ -111,7 +111,7 @@ export class FileViewerComponent implements OnInit, OnDestroy { | |||
|
|
|||
| if (publicProfile) { | |||
| publicProfile.archive$()?.subscribe((archive) => { | |||
| this.allowDownloads = archive.allowPublicDownload; | |||
| this.allowDownloads = !!archive?.allowPublicDownload; | |||
There was a problem hiding this comment.
This change was made by Prettier.
meisekimiu
requested review from
liam-lloyd,
cecilia-donnelly and
crisnicandrei
liam-lloyd
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
@angular-eslint/template/eqeqeqlinting rule. This also includes tests for one of the modified components, the file-viewer component which used the==operator instead of===. The other modified component, the connector component, already has some level of test coverage. Further refactoring of that component can be done once we finally decide to remove the Facebook connector completely (including the message showing its removal).