Upgrade Storybook and its dependencies (including @babel/traverse)
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot created an automatic pull request to bump some vulnerabilities, specifically the @babel/traverse package. Unfortunately, it just bumped the Storybook versions somewhat naively and the resulting PR actually ended up breaking Storybook. Instead, run the Storybook upgrade script with the following command: `npx storybook@latest upgrade` This upgraded all Storybook packages and dependencies, and also ran relevant automigrations so Storybook can continue to work. Original Dependabot PR: #315
As part of a quarterly goal to raise test coverage, add some tests so that this PR increases test coverage. These two tests cover some code that was originally untested in the AnnouncementComponent. The code adjusts various elements on the page when the announcement appoint appears and disappears, and this was originally written as a quick fix that probably wasn't deemed testable at the time. However, shallow-render allows us to render additional HTML in the page besides our component, so we can add in some external divs to be adjusted by the AnnouncementComponent for testing.
The tests were modified, so let's run Prettier on the entire component code as well.
This was included accidentally in the codecov change. Undo it so that coverage is only generated when we ask for it.
meisekimiu
force-pushed
the
dependabot-babel-traverse-storybook
branch
from
42fb075 to
a98628b
Compare
meisekimiu
requested review from
cecilia-donnelly,
liam-lloyd and
crisnicandrei
liam-lloyd
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot created an automatic pull request to bump some vulnerabilities, specifically the @babel/traverse package. Unfortunately, it just bumped the Storybook versions somewhat naively and the resulting PR actually ended up breaking Storybook.
Storybook provides an easier and more comprehensive way to upgrade it by providing an upgrade script. So let's run the provided upgrade script instead.
Also, as part of quarterly goal, I have increased test coverage slightly by adding some tests to the AnnouncementComponent, because we have to start increasing test coverage somewhere.
Closes #315.