PER-9247 Increase the duration of system messages #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisnicandrei
changed the title
meisekimiu
approved these changes
Oct 3, 2023
|
@crisnicandrei This looks good, but doesn't seem to apply to the phone and email verification messages. Is there a reason for that? Can we incorporate them as well? |
|
@k8lyn6 what messages did you test with? This might be something different because email verification was working for me |
k8lyn6
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
@crisnicandrei sorry, I must've not refreshed after I deployed to dev and tried the verify email and phone number messages, because it's working now! I think this will be a really good improvement.
crisnicandrei
force-pushed
the
PER-9247-increase-message-duration
branch
from
5aa2192 to
70cd143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have increased the duration of the message popup from 3 seconds to 9, and I have also added a button which will close the message when clicked on.
Steps to test: