Per 9139 publish modal shows extra slash #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisekimiu
approved these changes
Oct 3, 2023
| ).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('adds only one slash in the url before p/archive', () => { |
There was a problem hiding this comment.
I think this test might be a bit too specific; what we probably want is to make sure that there are no duplicate slashes in general. Instead of testing in one place (before the p/archive), I think it might make more sense to test the entire URL for double slashes (or rather the pathname of the URL since the https:// bit at the beginning contains double slashes).
To make this testing easy we can take the string returned from pipe.transform() and put it into a URL object and test the pathname:
const url = new URL(pipe.transform(folder));
expect(url.pathname).not.toContain("//");
crisnicandrei
force-pushed
the
PER-9139-publish-modal-shows-extra-slash
branch
from
a16395c to
1e19dd2
Compare
crisnicandrei
force-pushed
the
PER-9139-publish-modal-shows-extra-slash
branch
from
96f438c to
ec2fa8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stepts to test:
1.Select a record.
2. Click share
3. The generated url should have only one slash before p/archive