-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PER-9361-Email and phone verification are broken; #302
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -41,6 +41,32 @@ describe('AccountService', () => { | |||||||
}, | ||||||||
get: (account: AccountVO) => Promise.reject({}), | ||||||||
}, | ||||||||
auth: { | ||||||||
verify: (account, token, type) => { | ||||||||
return new Observable((observer) => { | ||||||||
observer.next( | ||||||||
new AuthResponse({ | ||||||||
isSuccessful: true, | ||||||||
Results: [ | ||||||||
{ | ||||||||
data: [ | ||||||||
{ | ||||||||
AccountVO: { | ||||||||
primaryEmail: '[email protected]', | ||||||||
fullName: 'Test User', | ||||||||
emailStatus: 'status.auth.verified', | ||||||||
phoneStatus: 'status.auth.verified', | ||||||||
}, | ||||||||
}, | ||||||||
], | ||||||||
}, | ||||||||
], | ||||||||
}) | ||||||||
); | ||||||||
observer.complete(); | ||||||||
}); | ||||||||
}, | ||||||||
}, | ||||||||
}) | ||||||||
.mock(Router, { | ||||||||
navigate: (route: string[]) => Promise.resolve(true), | ||||||||
|
@@ -99,4 +125,38 @@ describe('AccountService', () => { | |||||||
expect(error).toEqual(expectedError); | ||||||||
} | ||||||||
}); | ||||||||
|
||||||||
it('should handle successful email verification', async () => { | ||||||||
const { instance } = shallow.createService(); | ||||||||
|
||||||||
const account = new AccountVO({ | ||||||||
primaryEmail: '[email protected]', | ||||||||
fullName: 'Test User', | ||||||||
keepLoggedIn: true, | ||||||||
emailStatus: 'status.auth.unverified', | ||||||||
}); | ||||||||
|
||||||||
instance.setAccount(account); | ||||||||
|
||||||||
await instance.verifyEmail('sampleToken'); | ||||||||
expect(instance.getAccount().emailStatus).toBe('status.auth.verified'); | ||||||||
expect(instance.getAccount().keepLoggedIn).toBeTrue(); | ||||||||
}); | ||||||||
|
||||||||
it('should handle successful phone verification', async () => { | ||||||||
const { instance } = shallow.createService(); | ||||||||
|
||||||||
const account = new AccountVO({ | ||||||||
primaryEmail: '[email protected]', | ||||||||
fullName: 'Test User', | ||||||||
keepLoggedIn: true, | ||||||||
phoneStatus: 'status.auth.unverified', | ||||||||
}); | ||||||||
|
||||||||
instance.setAccount(account); | ||||||||
|
||||||||
await instance.verifyEmail('sampleToken'); | ||||||||
expect(instance.getAccount().phoneStatus).toBe('status.auth.verified'); | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
expect(instance.getAccount().keepLoggedIn).toBeTrue(); | ||||||||
}); | ||||||||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a check for the
keepLoggedIn
behavior since that's what this particular ticket is all about. These tests otherwise just check for email/phone verification, and so pass even when copied over to the main branch. I'd like to see these tests fail if we run them if the specific bug addressed in this ticket isn't fixed, if that makes sense.