Per 9237 gift storage interface

[crisnicandrei]

This pr's purpose is the implementation of the gift storage interface.

I have added a new tab to the storage dialog accessed from the dropdown for the gift component. I have created a new component which in which the new form lies where the user must input the email, amount and the message. Upon confirmation a new modal pops up for confirmation.

[meisekimiu]

Can you rebase this on main and fix the conflicts?

[cecilia-donnelly]

This may have been preexisting, but I can now reach https://ng.permanent.org:4200/app/(private//dialog:storage/done) and see an empty screen in the modal. I think we always want something to appear in the modal, likely the "add storage" page by default.

More concerning, I tried gifting 1.2 GB of storage, which is not allowed since we are limiting to whole numbers of gigabytes. I got a 500 error back from the server with the message SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type bigint: "-1288490188.8"CONTEXT: unnamed portal parameter $1 = '...'. but the user-facing message was "Success!" We should also remove the decimal point from the placeholder text and have it just read "0" or similar to make it clear that users need to send only whole numbers of gbs as gifts. Here is the slack conversation where Robert suggested sticking to whole gbs for gifting. Mind you, the server error should have been a validation issue, not a sql error, so I'm also looking into that.

[crisnicandrei]

@cecilia-donnelly I have pushed some changes, could you please recheck? thanks

[cecilia-donnelly]

Thanks for validating the storage amount is a whole number! However, just disabling the button is very confusing. Can you add a red box around the problematic entry or something like that? (cc @k8lyn6 since this is really a design question - is there language you'd like to use for the error if a person tries to give 1.5 GB and we're only allowing them to gift integer gbs of storage?)

[k8lyn6]

@cecilia-donnelly How about: "Storage can only be gifted in 1GB increments."

[crisnicandrei]

@cecilia-donnelly @k8lyn6 should there be a message for invalid email addresses as well?

[k8lyn6]

@cecilia-donnelly users can gift storage to people who aren't Permanent members, correct? I don't think we normally have a message for invalid email addresses, so I don't think we need one here.

[crisnicandrei]

@k8lyn6 i have added a message if the string is not a valid message (e.g andrei instead of [email protected])

[cecilia-donnelly]

Note that @k8lyn6 and I talked about this earlier and we should hold off on merging/deploying this until we fix a couple backend bugs. Notably https://permanent.atlassian.net/browse/PER-9327.

[crisnicandrei]

@k8lyn6 @cecilia-donnelly @meisekimiu I have tested this with the backend changes, and it looks good so I would say it can be reviewed