PER-9422

Renamed the files from banner to mobile-banner for less confusion.

src/app/auth/components/auth/auth.component.html

@@ -5,7 +5,7 @@
   </a>
   </div>
 </div>
-<pr-banner></pr-banner>
+<pr-mobile-banner></pr-mobile-banner>
 <pr-announcement></pr-announcement>
 <pr-android-app-notify></pr-android-app-notify>
 <pr-prompt></pr-prompt>

src/app/core/components/main/main.component.html

@@ -6,7 +6,7 @@
     <router-outlet name="dialog"></router-outlet>
   </div>
 </div>
-<pr-banner></pr-banner>
+<pr-mobile-banner></pr-mobile-banner>
 <pr-upload-progress></pr-upload-progress>
 <pr-dialog-root></pr-dialog-root>
 <pr-folder-picker></pr-folder-picker>

src/app/onboarding/components/onboarding/onboarding.component.html

@@ -44,6 +44,6 @@
 <ng-template #loading>
   <div class="loading">Loading...</div>
 </ng-template>
-<pr-banner></pr-banner>
+<pr-mobile-banner></pr-mobile-banner>
 <pr-prompt></pr-prompt>
 <pr-dialog-root></pr-dialog-root>

src/app/shared/components/banner/banner.component.spec.ts → src/app/shared/components/mobile-banner/mobile-banner.component.spec.ts

@@ -2,8 +2,8 @@
 import { SharedModule } from '@shared/shared.module';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { Shallow } from 'shallow-render';
-import { BannerService } from '@shared/services/banner/banner.service';
-import { BannerComponent } from './banner.component';
+import { MobileBannerService } from '@shared/services/mobile-banner/mobile-banner.service';
+import { MobileBannerComponent } from './mobile-banner.component';
 
 const mockBannerService = {
   get isIos() {
@@ -21,12 +21,12 @@ const mockBannerService = {
   hideBanner() {},
 };
 
-describe('BannerComponent', () => {
-  let shallow: Shallow<BannerComponent>;
+describe('MobileBannerComponent', () => {
+  let shallow: Shallow<MobileBannerComponent>;
 
   beforeEach(() => {
-    shallow = new Shallow(BannerComponent, SharedModule)
-      .mock(BannerService, mockBannerService)
+    shallow = new Shallow(MobileBannerComponent, SharedModule)
+      .mock(MobileBannerService, mockBannerService)
       .dontMock(NoopAnimationsModule)
       .import(NoopAnimationsModule);
   });

src/app/shared/components/banner/banner.component.ts → src/app/shared/components/mobile-banner/mobile-banner.component.ts

@@ -2,18 +2,18 @@
 import { PromptService } from '@shared/services/prompt/prompt.service';
 import { ngIfSlideUpAnimation } from '@shared/animations';
 import { Component } from '@angular/core';
-import { BannerService } from '@shared/services/banner/banner.service';
+import { MobileBannerService } from '@shared/services/mobile-banner/mobile-banner.service';
 
 @Component({
-  selector: 'pr-banner',
-  templateUrl: './banner.component.html',
-  styleUrls: ['./banner.component.scss'],
+  selector: 'pr-mobile-banner',
+  templateUrl: './mobile-banner.component.html',
+  styleUrls: ['./mobile-banner.component.scss'],
   animations: [ngIfSlideUpAnimation],
 })
-export class BannerComponent {
+export class MobileBannerComponent {
   public url = '';
   constructor(
-    public bannerService: BannerService,
+    public bannerService: MobileBannerService,
     private prompt: PromptService
   ) {
     this.url = this.bannerService.isIos

src/app/shared/services/banner/banner.service.spec.ts → src/app/shared/services/mobile-banner/mobile-banner.service.spec.ts

@@ -1,9 +1,8 @@
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 /* @format */
 import { DeviceService } from '@shared/services/device/device.service';
 import { CoreModule } from '@core/core.module';
 import { Shallow } from 'shallow-render';
-import { BannerService } from './banner.service';
+import { MobileBannerService } from './mobile-banner.service';
 
 const mockAndroidDeviceService = {
   isAndroid: () => true,
@@ -15,11 +14,11 @@ const mockIosDeviceService = {
 };
 
 describe('BannerService', () => {
-  let shallow: Shallow<BannerService>;
+  let shallow: Shallow<MobileBannerService>;
 
   describe('when on an Android device', () => {
     beforeEach(() => {
-      shallow = new Shallow(BannerService, CoreModule).mock(
+      shallow = new Shallow(MobileBannerService, CoreModule).mock(
         DeviceService,
         mockAndroidDeviceService
       );
@@ -36,7 +35,7 @@ describe('BannerService', () => {
 
   describe('when on an iOS device', () => {
     beforeEach(() => {
-      shallow = new Shallow(BannerService, CoreModule).mock(
+      shallow = new Shallow(MobileBannerService, CoreModule).mock(
         DeviceService,
         mockIosDeviceService
       );
@@ -46,7 +45,7 @@ describe('BannerService', () => {
       const { instance } = await shallow.createService();
 
       expect(instance.isVisible).toBeTrue();
-      
+
       expect(instance.isIos).toBeTrue();
     });
   });

src/app/shared/services/banner/banner.service.ts → src/app/shared/services/mobile-banner/mobile-banner.service.ts

@@ -5,12 +5,12 @@ import { Injectable } from '@angular/core';
 @Injectable({
   providedIn: 'root',
 })
-export class BannerService {
+export class MobileBannerService {
   private _isVisible = false;
-  private _appStoreUrl =
-    'https://apps.apple.com/app/permanent-archive/id1571883070' as const;
-  private _playStoreUrl =
-    'https://play.google.com/store/apps/details?id=org.permanent.PermanentArchive' as const;
+  private readonly _appStoreUrl =
+    'https://apps.apple.com/app/permanent-archive/id1571883070';
+  private readonly _playStoreUrl =
+    'https://play.google.com/store/apps/details?id=org.permanent.PermanentArchive';
 
   private _isIos = false;
 

src/app/shared/shared.module.ts

@@ -66,7 +66,7 @@ import { PrependProtocolPipe } from './pipes/prepend-protocol.pipe';
 import { SwitcherComponent } from './components/switcher/switcher.component';
 import { GetAltTextPipe } from './pipes/get-alt-text.pipe';
 import { AccessRolePipe } from './pipes/access-role.pipe';
-import { BannerComponent } from './components/banner/banner.component';
+import { MobileBannerComponent } from './components/mobile-banner/mobile-banner.component';
 
 @NgModule({
   imports: [
@@ -134,7 +134,7 @@ import { BannerComponent } from './components/banner/banner.component';
     SwitcherComponent,
     GetAltTextPipe,
     AccessRolePipe,
-    BannerComponent,
+    MobileBannerComponent,
   ],
   declarations: [
     ThumbnailComponent,
@@ -183,7 +183,7 @@ import { BannerComponent } from './components/banner/banner.component';
     SwitcherComponent,
     GetAltTextPipe,
     AccessRolePipe,
-    BannerComponent,
+    MobileBannerComponent,
   ],
   providers: [PublicLinkPipe, PublicRoutePipe, PrLocationPipe, DatePipe],
 })