Skip to content

Commit

Permalink
Resolved font issues found on testing
Browse files Browse the repository at this point in the history
Also changed text from "Register" to "Sign Up"
Minor paddings added
  • Loading branch information
luciancerbu-vsp committed Sep 18, 2024
1 parent 9eec515 commit a59c240
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
5 changes: 3 additions & 2 deletions Permanent/Modules/Authentication/Screens/LoginView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ struct LoginView: View {
.layoutPriority(0.5)

}
SmallRoundButtonImageView(type: .noColor, imagePlace: .onRight, text: "Register", image: Image(.iconauthUserPlus), action: {
SmallRoundButtonImageView(type: .noColor, imagePlace: .onRight, text: "Sign Up", image: Image(.iconauthUserPlus), action: {
})
.buttonStyle(NoTapAnimationStyle())

Expand All @@ -100,8 +100,9 @@ struct LoginView: View {
}
}
.padding(Constants.Design.isPhone ? 32 : 64)
.padding(.leading, Constants.Design.isPhone ? 32 : 0)
.padding(.leading, Constants.Design.isPhone ? 0 : -16)
.padding(.top, Constants.Design.isPhone ? 32 : 0)
.padding(.bottom, Constants.Design.isPhone ? 8 : 0)
ErrorBannerView(message: viewModel.bannerErrorMessage, isVisible: $viewModel.showErrorBanner)
}
.onChange(of: viewModel.loginStatus, perform: { status in
Expand Down
11 changes: 6 additions & 5 deletions Permanent/Modules/Authentication/Views/CustomLoginFormView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ struct CustomLoginFormView: View {

var body: some View {
VStack(spacing: 20) {
TextField("Username", text: $username)
.textStyle(UsualRegularMediumTextStyle())
TextField("", text: $username)
.textStyle(UsualSmallXRegularTextStyle())
.placeholder(when: username.isEmpty) {
Text("Email address".uppercased())
.font(.custom("Usual", size: 10))
.kerning(1.6)
.foregroundColor(.white)
.font(.custom("Usual-Regular", size: 10))
.kerning(1.6)
.lineLimit(1)
}
.foregroundColor(.white)
Expand All @@ -52,7 +52,8 @@ struct CustomLoginFormView: View {
focusedField = .username
}

SecureField("Password", text: $password)
SecureField("", text: $password)
.font(.custom("Usual-Regular", size: 14))
.foregroundColor(.white)
.placeholder(when: password.isEmpty) {
Text("Password".uppercased())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,6 @@ struct ErrorBannerView: View {
}
}
.padding(.horizontal, Constants.Design.isPhone ? 32 : 64) // Adjust this padding as needed for the notification's position
.padding(.leading, Constants.Design.isPhone ? 0 : -16)
}
}

0 comments on commit a59c240

Please sign in to comment.