Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smb errors): getErrorString only returns one item, not a tuple #119

Merged
merged 1 commit into from
Nov 26, 2023
Merged

fix(smb errors): getErrorString only returns one item, not a tuple #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions nxc/protocols/smb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def kerberos_login(self, domain, username, password="", ntlm_hash="", aesKey="",
used_ccache = f" through S4U with {username}"
self.logger.fail(f"{domain}\\{self.username}{used_ccache} {e}")
except (SessionError, Exception) as e:
error, desc = e.getErrorString()
error = e.getErrorString()
used_ccache = " from ccache" if useCache else f":{process_secret(kerb_pass)}"
if self.args.delegate:
used_ccache = f" through S4U with {username}"
Expand Down Expand Up @@ -500,7 +500,7 @@ def plaintext_login(self, domain, username, password):
self.create_conn_obj()
return True
except SessionError as e:
error, desc = e.getErrorString()
error = e.getErrorString()
self.logger.fail(
f'{domain}\\{self.username}:{process_secret(self.password)} {error} {f"({desc})" if self.args.verbose else ""}',
color="magenta" if error in smb_error_status else "red",
Expand Down Expand Up @@ -563,7 +563,7 @@ def hash_login(self, domain, username, ntlm_hash):
self.create_conn_obj()
return True
except SessionError as e:
error, desc = e.getErrorString()
error = e.getErrorString()
self.logger.fail(
f"{domain}\\{self.username}:{process_secret(self.hash)} {error} {f'({desc})' if self.args.verbose else ''}",
color="magenta" if error in smb_error_status else "red",
Expand Down Expand Up @@ -920,7 +920,7 @@ def disks(self):
for disk in disks:
self.logger.highlight(disk.disk)
except Exception as e:
error, desc = e.getErrorString()
error = e.getErrorString()
self.logger.fail(
f"Error enumerating disks: {error}",
color="magenta" if error in smb_error_status else "red",
Expand Down
Loading